chore(selenium): use dockerized selenium setup for tests#17708
chore(selenium): use dockerized selenium setup for tests#17708gh-worker-dd-mergequeue-cf854d[bot] merged 5 commits intomainfrom
Conversation
Codeowners resolved as |
Performance SLOsComparing candidate gnufede/docker-selenium (85a0215) with baseline main (791f853) 📈 Performance Regressions (2 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 103.698µs (SLO: <130.000µs 📉 -20.2%) vs baseline: +2.8% Memory: ✅ 43.957MB (SLO: <46.000MB -4.4%) vs baseline: +4.9% ✅ add_inplace_aspectTime: ✅ 101.491µs (SLO: <130.000µs 📉 -21.9%) vs baseline: +1.0% Memory: ✅ 44.013MB (SLO: <46.000MB -4.3%) vs baseline: +5.3% ✅ add_inplace_noaspectTime: ✅ 28.250µs (SLO: <40.000µs 📉 -29.4%) vs baseline: ~same Memory: ✅ 43.991MB (SLO: <46.000MB -4.4%) vs baseline: +5.0% ✅ add_noaspectTime: ✅ 49.005µs (SLO: <70.000µs 📉 -30.0%) vs baseline: -0.6% Memory: ✅ 43.857MB (SLO: <46.000MB -4.7%) vs baseline: +4.8% ✅ bytearray_aspectTime: ✅ 264.224µs (SLO: <400.000µs 📉 -33.9%) vs baseline: -1.7% Memory: ✅ 43.911MB (SLO: <46.000MB -4.5%) vs baseline: +5.0% ✅ bytearray_extend_aspectTime: ✅ 662.205µs (SLO: <800.000µs 📉 -17.2%) vs baseline: +1.4% Memory: ✅ 44.045MB (SLO: <46.000MB -4.3%) vs baseline: +5.2% ✅ bytearray_extend_noaspectTime: ✅ 272.786µs (SLO: <400.000µs 📉 -31.8%) vs baseline: +1.0% Memory: ✅ 43.920MB (SLO: <46.000MB -4.5%) vs baseline: +4.7% ✅ bytearray_noaspectTime: ✅ 147.184µs (SLO: <300.000µs 📉 -50.9%) vs baseline: +1.0% Memory: ✅ 43.890MB (SLO: <46.000MB -4.6%) vs baseline: +4.6% ✅ bytes_aspectTime: ✅ 228.988µs (SLO: <300.000µs 📉 -23.7%) vs baseline: -1.2% Memory: ✅ 43.886MB (SLO: <46.000MB -4.6%) vs baseline: +4.7% ✅ bytes_noaspectTime: ✅ 139.001µs (SLO: <200.000µs 📉 -30.5%) vs baseline: -1.7% Memory: ✅ 43.914MB (SLO: <46.000MB -4.5%) vs baseline: +4.7% ✅ bytesio_aspectTime: ✅ 3.849ms (SLO: <5.000ms 📉 -23.0%) vs baseline: +0.6% Memory: ✅ 44.052MB (SLO: <46.000MB -4.2%) vs baseline: +5.2% ✅ bytesio_noaspectTime: ✅ 317.678µs (SLO: <420.000µs 📉 -24.4%) vs baseline: -1.8% Memory: ✅ 43.912MB (SLO: <46.000MB -4.5%) vs baseline: +4.8% ✅ capitalize_aspectTime: ✅ 89.574µs (SLO: <300.000µs 📉 -70.1%) vs baseline: ~same Memory: ✅ 43.916MB (SLO: <46.000MB -4.5%) vs baseline: +5.1% ✅ capitalize_noaspectTime: ✅ 254.364µs (SLO: <300.000µs 📉 -15.2%) vs baseline: +0.6% Memory: ✅ 43.795MB (SLO: <46.000MB -4.8%) vs baseline: +4.6% ✅ casefold_aspectTime: ✅ 92.152µs (SLO: <500.000µs 📉 -81.6%) vs baseline: +3.2% Memory: ✅ 43.858MB (SLO: <46.000MB -4.7%) vs baseline: +4.7% ✅ casefold_noaspectTime: ✅ 313.367µs (SLO: <500.000µs 📉 -37.3%) vs baseline: -0.5% Memory: ✅ 43.890MB (SLO: <46.000MB -4.6%) vs baseline: +4.7% ✅ decode_aspectTime: ✅ 86.670µs (SLO: <100.000µs 📉 -13.3%) vs baseline: -0.2% Memory: ✅ 43.841MB (SLO: <46.000MB -4.7%) vs baseline: +4.5% ✅ decode_noaspectTime: ✅ 156.556µs (SLO: <210.000µs 📉 -25.4%) vs baseline: -1.3% Memory: ✅ 43.877MB (SLO: <46.000MB -4.6%) vs baseline: +5.0% ✅ encode_aspectTime: ✅ 84.797µs (SLO: <200.000µs 📉 -57.6%) vs baseline: -0.4% Memory: ✅ 44.023MB (SLO: <46.000MB -4.3%) vs baseline: +5.0% ✅ encode_noaspectTime: ✅ 145.941µs (SLO: <200.000µs 📉 -27.0%) vs baseline: +0.3% Memory: ✅ 43.906MB (SLO: <46.000MB -4.6%) vs baseline: +4.7% ✅ format_aspectTime: ✅ 14.614ms (SLO: <19.200ms 📉 -23.9%) vs baseline: ~same Memory: ✅ 43.932MB (SLO: <46.000MB -4.5%) vs baseline: +4.7% ✅ format_map_aspectTime: ✅ 16.352ms (SLO: <21.500ms 📉 -23.9%) vs baseline: ~same Memory: ✅ 44.010MB (SLO: <46.000MB -4.3%) vs baseline: +5.1% ✅ format_map_noaspectTime: ✅ 361.348µs (SLO: <500.000µs 📉 -27.7%) vs baseline: +0.2% Memory: ✅ 43.960MB (SLO: <46.000MB -4.4%) vs baseline: +4.9% ✅ format_noaspectTime: ✅ 312.522µs (SLO: <500.000µs 📉 -37.5%) vs baseline: ~same Memory: ✅ 43.852MB (SLO: <46.000MB -4.7%) vs baseline: +4.7% ✅ index_aspectTime: ✅ 123.274µs (SLO: <300.000µs 📉 -58.9%) vs baseline: +0.3% Memory: ✅ 43.974MB (SLO: <46.000MB -4.4%) vs baseline: +5.0% ✅ index_noaspectTime: ✅ 40.698µs (SLO: <300.000µs 📉 -86.4%) vs baseline: -0.1% Memory: ✅ 43.975MB (SLO: <46.000MB -4.4%) vs baseline: +4.7% ✅ join_aspectTime: ✅ 216.236µs (SLO: <300.000µs 📉 -27.9%) vs baseline: +0.4% Memory: ✅ 43.885MB (SLO: <46.000MB -4.6%) vs baseline: +4.8% ✅ join_noaspectTime: ✅ 142.599µs (SLO: <300.000µs 📉 -52.5%) vs baseline: -0.8% Memory: ✅ 43.957MB (SLO: <46.000MB -4.4%) vs baseline: +4.9% ✅ ljust_aspectTime: ✅ 503.615µs (SLO: <700.000µs 📉 -28.1%) vs baseline: +0.1% Memory: ✅ 43.902MB (SLO: <46.000MB -4.6%) vs baseline: +4.4% ✅ ljust_noaspectTime: ✅ 260.431µs (SLO: <300.000µs 📉 -13.2%) vs baseline: ~same Memory: ✅ 43.955MB (SLO: <46.000MB -4.4%) vs baseline: +5.0% ✅ lower_aspectTime: ✅ 309.392µs (SLO: <500.000µs 📉 -38.1%) vs baseline: +0.3% Memory: ✅ 43.874MB (SLO: <46.000MB -4.6%) vs baseline: +4.7% ✅ lower_noaspectTime: ✅ 237.887µs (SLO: <300.000µs 📉 -20.7%) vs baseline: +0.4% Memory: ✅ 43.958MB (SLO: <46.000MB -4.4%) vs baseline: +5.1% ✅ lstrip_aspectTime: ✅ 0.344ms (SLO: <3.000ms 📉 -88.5%) vs baseline: 📈 +25.0% Memory: ✅ 43.952MB (SLO: <46.000MB -4.5%) vs baseline: +5.2% ✅ lstrip_noaspectTime: ✅ 0.176ms (SLO: <3.000ms 📉 -94.1%) vs baseline: -1.7% Memory: ✅ 43.782MB (SLO: <46.000MB -4.8%) vs baseline: +4.4% ✅ modulo_aspectTime: ✅ 14.218ms (SLO: <18.750ms 📉 -24.2%) vs baseline: ~same Memory: ✅ 43.849MB (SLO: <46.000MB -4.7%) vs baseline: +4.6% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 14.706ms (SLO: <19.350ms 📉 -24.0%) vs baseline: -0.4% Memory: ✅ 44.061MB (SLO: <46.000MB -4.2%) vs baseline: +5.3% ✅ modulo_aspect_for_bytesTime: ✅ 14.387ms (SLO: <18.900ms 📉 -23.9%) vs baseline: ~same Memory: ✅ 43.915MB (SLO: <46.000MB -4.5%) vs baseline: +4.9% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 14.611ms (SLO: <19.150ms 📉 -23.7%) vs baseline: ~same Memory: ✅ 44.100MB (SLO: <46.000MB -4.1%) vs baseline: +5.3% ✅ modulo_noaspectTime: ✅ 0.361ms (SLO: <3.000ms 📉 -88.0%) vs baseline: -0.9% Memory: ✅ 43.906MB (SLO: <46.000MB -4.6%) vs baseline: +4.8% ✅ replace_aspectTime: ✅ 18.341ms (SLO: <24.000ms 📉 -23.6%) vs baseline: +0.1% Memory: ✅ 44.100MB (SLO: <46.000MB -4.1%) vs baseline: +5.1% ✅ replace_noaspectTime: ✅ 305.491µs (SLO: <400.000µs 📉 -23.6%) vs baseline: +6.2% Memory: ✅ 43.977MB (SLO: <46.000MB -4.4%) vs baseline: +4.9% ✅ repr_aspectTime: ✅ 321.299µs (SLO: <420.000µs 📉 -23.5%) vs baseline: -0.9% Memory: ✅ 43.910MB (SLO: <46.000MB -4.5%) vs baseline: +4.7% ✅ repr_noaspectTime: ✅ 46.480µs (SLO: <90.000µs 📉 -48.4%) vs baseline: -0.6% Memory: ✅ 43.978MB (SLO: <46.000MB -4.4%) vs baseline: +5.0% ✅ rstrip_aspectTime: ✅ 387.386µs (SLO: <500.000µs 📉 -22.5%) vs baseline: ~same Memory: ✅ 43.926MB (SLO: <46.000MB -4.5%) vs baseline: +5.1% ✅ rstrip_noaspectTime: ✅ 184.618µs (SLO: <300.000µs 📉 -38.5%) vs baseline: ~same Memory: ✅ 43.975MB (SLO: <46.000MB -4.4%) vs baseline: +5.2% ✅ slice_aspectTime: ✅ 181.126µs (SLO: <300.000µs 📉 -39.6%) vs baseline: -0.7% Memory: ✅ 43.886MB (SLO: <46.000MB -4.6%) vs baseline: +4.4% ✅ slice_noaspectTime: ✅ 53.797µs (SLO: <90.000µs 📉 -40.2%) vs baseline: +0.3% Memory: ✅ 43.967MB (SLO: <46.000MB -4.4%) vs baseline: +4.8% ✅ stringio_aspectTime: ✅ 3.866ms (SLO: <5.000ms 📉 -22.7%) vs baseline: -0.4% Memory: ✅ 43.902MB (SLO: <46.000MB -4.6%) vs baseline: +4.5% ✅ stringio_noaspectTime: ✅ 356.636µs (SLO: <500.000µs 📉 -28.7%) vs baseline: -0.1% Memory: ✅ 44.014MB (SLO: <46.000MB -4.3%) vs baseline: +5.2% ✅ strip_aspectTime: ✅ 275.384µs (SLO: <350.000µs 📉 -21.3%) vs baseline: +0.4% Memory: ✅ 43.949MB (SLO: <46.000MB -4.5%) vs baseline: +4.9% ✅ strip_noaspectTime: ✅ 176.513µs (SLO: <240.000µs 📉 -26.5%) vs baseline: ~same Memory: ✅ 43.851MB (SLO: <46.000MB -4.7%) vs baseline: +4.6% ✅ swapcase_aspectTime: ✅ 343.817µs (SLO: <500.000µs 📉 -31.2%) vs baseline: -1.8% Memory: ✅ 43.895MB (SLO: <46.000MB -4.6%) vs baseline: +4.7% ✅ swapcase_noaspectTime: ✅ 275.302µs (SLO: <400.000µs 📉 -31.2%) vs baseline: +0.8% Memory: ✅ 43.895MB (SLO: <46.000MB -4.6%) vs baseline: +4.7% ✅ title_aspectTime: ✅ 338.546µs (SLO: <500.000µs 📉 -32.3%) vs baseline: -1.4% Memory: ✅ 43.910MB (SLO: <46.000MB -4.5%) vs baseline: +4.6% ✅ title_noaspectTime: ✅ 263.110µs (SLO: <400.000µs 📉 -34.2%) vs baseline: +0.6% Memory: ✅ 43.919MB (SLO: <46.000MB -4.5%) vs baseline: +5.0% ✅ translate_aspectTime: ✅ 574.285µs (SLO: <700.000µs 📉 -18.0%) vs baseline: 📈 +11.4% Memory: ✅ 43.935MB (SLO: <46.000MB -4.5%) vs baseline: +5.0% ✅ translate_noaspectTime: ✅ 430.578µs (SLO: <500.000µs 📉 -13.9%) vs baseline: -0.3% Memory: ✅ 43.919MB (SLO: <46.000MB -4.5%) vs baseline: +4.9% ✅ upper_aspectTime: ✅ 318.066µs (SLO: <500.000µs 📉 -36.4%) vs baseline: +3.3% Memory: ✅ 43.982MB (SLO: <46.000MB -4.4%) vs baseline: +4.7% ✅ upper_noaspectTime: ✅ 241.522µs (SLO: <400.000µs 📉 -39.6%) vs baseline: +2.2% Memory: ✅ 43.921MB (SLO: <46.000MB -4.5%) vs baseline: +4.8% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 523.942µs (SLO: <700.000µs 📉 -25.2%) vs baseline: 📈 +24.7% Memory: ✅ 43.931MB (SLO: <46.000MB -4.5%) vs baseline: +4.8% ✅ ospathbasename_noaspectTime: ✅ 429.919µs (SLO: <700.000µs 📉 -38.6%) vs baseline: +0.5% Memory: ✅ 43.885MB (SLO: <46.000MB -4.6%) vs baseline: +5.1% ✅ ospathjoin_aspectTime: ✅ 627.539µs (SLO: <700.000µs 📉 -10.4%) vs baseline: -0.7% Memory: ✅ 43.843MB (SLO: <46.000MB -4.7%) vs baseline: +4.9% ✅ ospathjoin_noaspectTime: ✅ 637.694µs (SLO: <700.000µs -8.9%) vs baseline: -0.5% Memory: ✅ 43.914MB (SLO: <46.000MB -4.5%) vs baseline: +5.1% ✅ ospathnormcase_aspectTime: ✅ 352.603µs (SLO: <700.000µs 📉 -49.6%) vs baseline: +0.4% Memory: ✅ 43.817MB (SLO: <46.000MB -4.7%) vs baseline: +4.7% ✅ ospathnormcase_noaspectTime: ✅ 361.438µs (SLO: <700.000µs 📉 -48.4%) vs baseline: +1.5% Memory: ✅ 43.808MB (SLO: <46.000MB -4.8%) vs baseline: +4.9% ✅ ospathsplit_aspectTime: ✅ 481.789µs (SLO: <700.000µs 📉 -31.2%) vs baseline: -0.6% Memory: ✅ 43.938MB (SLO: <46.000MB -4.5%) vs baseline: +5.2% ✅ ospathsplit_noaspectTime: ✅ 491.273µs (SLO: <700.000µs 📉 -29.8%) vs baseline: -0.2% Memory: ✅ 43.925MB (SLO: <46.000MB -4.5%) vs baseline: +4.8% ✅ ospathsplitdrive_aspectTime: ✅ 370.570µs (SLO: <700.000µs 📉 -47.1%) vs baseline: -0.7% Memory: ✅ 43.809MB (SLO: <46.000MB -4.8%) vs baseline: +4.7% ✅ ospathsplitdrive_noaspectTime: ✅ 72.640µs (SLO: <700.000µs 📉 -89.6%) vs baseline: -1.1% Memory: ✅ 43.840MB (SLO: <46.000MB -4.7%) vs baseline: +4.7% ✅ ospathsplitext_aspectTime: ✅ 459.086µs (SLO: <700.000µs 📉 -34.4%) vs baseline: -0.7% Memory: ✅ 43.954MB (SLO: <46.000MB -4.4%) vs baseline: +4.7% ✅ ospathsplitext_noaspectTime: ✅ 465.076µs (SLO: <700.000µs 📉 -33.6%) vs baseline: ~same Memory: ✅ 43.997MB (SLO: <46.000MB -4.4%) vs baseline: +4.9% 🟡 Near SLO Breach (6 suites)🟡 djangosimple - 28/28✅ appsecTime: ✅ 19.633ms (SLO: <22.300ms 📉 -12.0%) vs baseline: ~same Memory: ✅ 71.300MB (SLO: <73.500MB -3.0%) vs baseline: +4.7% ✅ exception-replay-enabledTime: ✅ 1.363ms (SLO: <1.450ms -6.0%) vs baseline: -0.2% Memory: ✅ 69.649MB (SLO: <71.500MB -2.6%) vs baseline: +4.8% ✅ iastTime: ✅ 19.623ms (SLO: <22.250ms 📉 -11.8%) vs baseline: -0.4% Memory: ✅ 71.560MB (SLO: <75.000MB -4.6%) vs baseline: +5.1% ✅ profilerTime: ✅ 15.137ms (SLO: <16.550ms -8.5%) vs baseline: -0.7% Memory: ✅ 60.444MB (SLO: <61.000MB 🟡 -0.9%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 19.475ms (SLO: <21.750ms 📉 -10.5%) vs baseline: -0.4% Memory: ✅ 71.658MB (SLO: <73.500MB -2.5%) vs baseline: +5.1% ✅ span-code-originTime: ✅ 20.039ms (SLO: <28.200ms 📉 -28.9%) vs baseline: +1.2% Memory: ✅ 71.674MB (SLO: <75.000MB -4.4%) vs baseline: +4.8% ✅ tracerTime: ✅ 19.651ms (SLO: <21.750ms -9.7%) vs baseline: -0.3% Memory: ✅ 71.468MB (SLO: <75.000MB -4.7%) vs baseline: +4.8% ✅ tracer-and-profilerTime: ✅ 21.055ms (SLO: <23.500ms 📉 -10.4%) vs baseline: +0.3% Memory: ✅ 73.531MB (SLO: <75.000MB 🟡 -2.0%) vs baseline: +4.9% ✅ tracer-dont-create-db-spansTime: ✅ 19.696ms (SLO: <21.500ms -8.4%) vs baseline: +0.3% Memory: ✅ 71.418MB (SLO: <75.000MB -4.8%) vs baseline: +4.9% ✅ tracer-minimalTime: ✅ 17.818ms (SLO: <18.500ms -3.7%) vs baseline: -0.9% Memory: ✅ 71.494MB (SLO: <75.000MB -4.7%) vs baseline: +4.9% ✅ tracer-no-cachesTime: ✅ 18.860ms (SLO: <19.650ms -4.0%) vs baseline: +0.2% Memory: ✅ 71.426MB (SLO: <75.000MB -4.8%) vs baseline: +4.8% ✅ tracer-no-databasesTime: ✅ 20.602ms (SLO: <21.100ms -2.4%) vs baseline: -0.2% Memory: ✅ 71.490MB (SLO: <75.000MB -4.7%) vs baseline: +4.7% ✅ tracer-no-middlewareTime: ✅ 20.726ms (SLO: <21.500ms -3.6%) vs baseline: -0.5% Memory: ✅ 71.429MB (SLO: <75.000MB -4.8%) vs baseline: +4.7% ✅ tracer-no-templatesTime: ✅ 19.489ms (SLO: <22.000ms 📉 -11.4%) vs baseline: +0.4% Memory: ✅ 71.313MB (SLO: <73.500MB -3.0%) vs baseline: +4.7% 🟡 otelspan - 22/22✅ add-eventTime: ✅ 41.388ms (SLO: <47.150ms 📉 -12.2%) vs baseline: -0.6% Memory: ✅ 41.572MB (SLO: <47.000MB 📉 -11.5%) vs baseline: +4.9% ✅ add-metricsTime: ✅ 234.857ms (SLO: <344.800ms 📉 -31.9%) vs baseline: +0.4% Memory: ✅ 45.391MB (SLO: <47.500MB -4.4%) vs baseline: +4.6% ✅ add-tagsTime: ✅ 265.805ms (SLO: <330.000ms 📉 -19.5%) vs baseline: +0.3% Memory: ✅ 45.511MB (SLO: <47.500MB -4.2%) vs baseline: +4.7% ✅ get-contextTime: ✅ 81.162ms (SLO: <92.350ms 📉 -12.1%) vs baseline: +0.3% Memory: ✅ 41.347MB (SLO: <46.500MB 📉 -11.1%) vs baseline: +5.3% ✅ is-recordingTime: ✅ 38.004ms (SLO: <44.500ms 📉 -14.6%) vs baseline: ~same Memory: ✅ 40.860MB (SLO: <47.500MB 📉 -14.0%) vs baseline: +4.5% ✅ record-exceptionTime: ✅ 62.844ms (SLO: <67.650ms -7.1%) vs baseline: +0.2% Memory: ✅ 41.889MB (SLO: <47.000MB 📉 -10.9%) vs baseline: +4.9% ✅ set-statusTime: ✅ 43.586ms (SLO: <50.400ms 📉 -13.5%) vs baseline: ~same Memory: ✅ 40.905MB (SLO: <47.000MB 📉 -13.0%) vs baseline: +4.6% ✅ startTime: ✅ 39.073ms (SLO: <44.500ms 📉 -12.2%) vs baseline: +5.3% Memory: ✅ 40.810MB (SLO: <47.000MB 📉 -13.2%) vs baseline: +4.1% ✅ start-finishTime: ✅ 90.082ms (SLO: <92.000ms -2.1%) vs baseline: ~same Memory: ✅ 38.791MB (SLO: <46.500MB 📉 -16.6%) vs baseline: +4.8% ✅ start-finish-telemetryTime: ✅ 91.732ms (SLO: <93.000ms 🟡 -1.4%) vs baseline: +0.4% Memory: ✅ 38.889MB (SLO: <46.500MB 📉 -16.4%) vs baseline: +5.2% ✅ update-nameTime: ✅ 38.910ms (SLO: <45.150ms 📉 -13.8%) vs baseline: -0.2% Memory: ✅ 41.038MB (SLO: <47.000MB 📉 -12.7%) vs baseline: +4.7% 🟡 packagesupdateimporteddependencies - 24/24 (1 unstable)✅ import_manyTime: ✅ 167.235µs (SLO: <170.000µs 🟡 -1.6%) vs baseline: -1.7% Memory: ✅ 41.026MB (SLO: <46.000MB 📉 -10.8%) vs baseline: +4.6% ✅ import_many_cachedTime: ✅ 134.186µs (SLO: <170.000µs 📉 -21.1%) vs baseline: +1.5% Memory: ✅ 41.090MB (SLO: <46.000MB 📉 -10.7%) vs baseline: +5.1% ✅ import_many_stdlibTime: ✅ 1.255ms (SLO: <1.750ms 📉 -28.3%) vs baseline: +0.3% Memory: ✅ 41.435MB (SLO: <46.000MB -9.9%) vs baseline: +5.3%
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 85a02150de
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
emmettbutler
left a comment
There was a problem hiding this comment.
thanks for doing this
caa8f79
into
main
Description
The selenium tests were previously gated behind a
platform.machine() == "x86_64"check becauseselenium-manager(bundled with theseleniumpackage) has no binary forlinux/aarch64, making them impossible to run locally on Apple Silicon.This PR replaces the local
webdriver.Chromesetup withwebdriver.Remotepointing at aselenium/standalone-chromeDocker service (linux/amd64). This decouples the test runner architecture from the browser architecture, so tests run on any host.Changes:
docker-compose.yml: adds aselenium-chromeservice (selenium/standalone-chrome:latest,platform: linux/amd64,network_mode: host) so local runs viascripts/ddtestwork on arm64 hosts.gitlab/services.yml: registersselenium-chromeas a named GitLab CI service pointing at the internal registry mirrortests/ci_visibility/suitespec.yml: addsselenium-chrometo the selenium suite's required services and setsSELENIUM_GRID_URL=http://selenium-chrome:4444for CI (where services are accessed by hostname alias rather thanlocalhost)test_selenium_chrome.py: removes thex86_64skipif guards and theplatformimport; extracts a_make_driver()helper that useswebdriver.RemotewithSELENIUM_GRID_URL(defaults tohttp://localhost:4444for local runs)test.source.start/test.source.endmetrics to reflect the refactored test script line numbers; also addedmeta._dd.svc_srcandmeta._dd.tags.processto the snapshot ignore list (new fields emitted by newer ddtrace versions)Testing
scripts/run-testswith theselenium-chromeDocker service active — all passtest_selenium_v3_plugin_tags(mock-based, no real browser) continues to pass as beforeRisks
selenium/standalone-chrome:latestis a mutable tag — if the image is updated it may change browser/driver versions. The snapshot ignore list already excludestest.browser.versionandtest.browser.driver_versionso this is safe.Additional Notes
The
SELENIUM_GRID_URLenv var allows the grid endpoint to be overridden without code changes, which is useful if the service is ever moved or renamed.